This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_formatter): Dedent IR
#3007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a new IR that allows to reduce the indention for some content nested inside of an `align` or `indent`. The behaviour of the element depends on whether the closest ancestor is an `align` or `indent` * `align`: Removes the `align` spaces * `indent`: Reduces the indention level by one *EXCEPT* if the level is 0, in which case this is a no-op This is necessary for the formatting of nested conditional expressions where the `consequent` gets wrapped in an `align` but any nested consequent should be indented by one level (and not an indent). That's why the formatter uses `deden(indent(...))` to undo the `align` but enforce an `indent`.
Deploying with
|
| Latest commit: |
4c9e9b5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://515ada42.tools-8rn.pages.dev |
| Branch Preview URL: | https://feat-dedent-format-element.tools-8rn.pages.dev |
ematipico
reviewed
Aug 5, 2022
leops
approved these changes
Aug 5, 2022
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 10, 2022
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new IR that allows to reduce the indention for some content nested inside of an
alignorindent.The behaviour of the element depends on whether the closest ancestor is an
alignorindentalign: Removes thealignspacesindent: Reduces the indention level by one EXCEPT if the level is 0, in which case this is a no-opThis is necessary for the formatting of nested conditional expressions where the
consequentgets wrapped in analignbut any nested consequent should be indented by one level (and not an indent). That's why the formatter usesdedent(indent(...))to undo thealignbut enforce anindent.Test Plan
I added a new builder test showing the behaviour of the
dedentelement.