This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat: add no extra boolean cast #2992
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add analysis for extra boolean cast
add js call expression query to check no extra boolean cast
|
#2868, seems duplicate. |
|
Thank you @ktfth for your contribution, but unfortunately there's already a PR to implement this rule. I suggest to check first if a rule hasn't been claimed/assigned by anyone, so we can avoid duplicates. In the umbrella issue we also wrote instructions of how to claim a rule. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From umbrella ticket #2642
noExtraBooleanCast
Disallow unnecessary boolean casts
Example fix:
if (Boolean(foo)) {} -> if (foo) {}