+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_service): inject defaults for missing globals #2998

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

ematipico
Copy link
Contributor

Summary

Fixes #2996

Test Plan

Created a new test, using the same configuration of the issue.

@ematipico ematipico requested a review from leops as a code owner August 3, 2022 16:56
@ematipico ematipico temporarily deployed to aws August 3, 2022 16:56 Inactive
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 39717bf
Status: ✅  Deploy successful!
Preview URL: https://57175175.tools-8rn.pages.dev
Branch Preview URL: https://fix-globals-throw-error.tools-8rn.pages.dev

View logs

@ematipico ematipico added the A-Project Area: project configuration and loading label Aug 3, 2022
@ematipico ematipico requested a review from a team August 4, 2022 07:33
@ematipico ematipico merged commit c55a51d into main Aug 4, 2022
@ematipico ematipico deleted the fix/globals-throw-error branch August 4, 2022 08:58
IWANABETHATGUY pushed a commit to IWANABETHATGUY/tools that referenced this pull request Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Project Area: project configuration and loading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Configration javascript.globals seems to be required, but not undocumented
2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载