This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): improve trivia handling in useSingleVarDeclarator #2955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
Deploying with
|
| Latest commit: |
e93b052
|
| Status: | ⚡️ Build in progress... |
ematipico
approved these changes
Jul 29, 2022
crates/rome_js_analyze/src/analyzers/js/use_single_var_declarator.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/js/use_single_var_declarator.rs
Outdated
Show resolved
Hide resolved
1 task
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
…or (rome#2955) * fix(rome_js_analyze): improve trivia handling in useSingleVarDeclarator * update documentation * PR review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #2945 by improving how trivia is handled as tokens are moved in the syntax tree mutation. Since that rule isn't really safe to apply I've downgraded its applicability to
MaybeIncorrect, and modified the CLI tests that were relying on thisI also fixed the issue of separated lists created with the node factory API having an empty slot at the end of the list if the trailing separator was
Noneby having the factory function take two iterators (one for the list elements and one for the separators) instead of a single iterator of pairs of list element + an optional separator token. The content of the two iterators are interleaved while building the list, and the separator iterator can simply be one item shorter than the elements iterator in order to omit the last separator without creating an empty slotTest Plan
I've added the problematic cases from #2945 to the tests for the
useSingleVarDeclaratorrule, the code actions being emitted for these are now correct