This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_semantic): bug when hoisting function scope #2940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR solves a bug when renaming functions and will impact #2835. |
Deploying with
|
| Latest commit: |
4042fab
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a56d66d7.tools-8rn.pages.dev |
| Branch Preview URL: | https://fix-hoisting-scope.tools-8rn.pages.dev |
leops
approved these changes
Jul 28, 2022
Could you please update the issue and leave a note of how this PR will impact the release? |
ematipico
reviewed
Jul 28, 2022
| @@ -396,7 +400,15 @@ impl SemanticModel { | |||
| } | |||
| } | |||
|
|
|||
| /// Return the [Scope] which the syntax is part of. | |||
| /// Returns the global scope of the model | |||
| pub fn global_scope(&self) -> Scope { | |||
There was a problem hiding this comment.
You finally created it! 😝
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
* fix hoisting scope when building semantic model
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Creates the distinction between "scope" and "scope_hoisted_to" for declarations that are hoisted. This gives more information on where to look at conflicts when renaming symbols.
And fix a bug when renaming functions.
Will enable #2926 to be merged.
Test Plan