This repository was archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
Latest commit: |
2390975
|
Status: | ✅ Deploy successful! |
Preview URL: | https://0b55dad4.tools-8rn.pages.dev |
Branch Preview URL: | https://chore-update-eleventy.tools-8rn.pages.dev |
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
MichaReiser
approved these changes
Jul 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No concerns related to the upgrade but it seems to me that this PR also contains the recommended rule changes. Can we split the PR?
</h3> | ||
Disallows using an async function as a Promise executor. | ||
</div> | ||
<div class="rule"> | ||
<h3 data-toc-exclude id="noCatchAssign"> | ||
<a href="/docs/lint/rules/noCatchAssign">noCatchAssign (since v0.7.0)</a> | ||
<a class="header-anchor" href="#noCatchAssign"></a> | ||
<span class="recommended">recommended</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be part of this PR?
It's a stacked PR, the PR of the recommended rules was merged into this PR. #2937 |
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades
eleventy
package inside our website. The version we had was really old.I fixed some regressions that popped out.
Test Plan
The deployed website should work