+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

chore(website): upgrade eleventy #2934

Merged
merged 2 commits into from
Jul 28, 2022
Merged

chore(website): upgrade eleventy #2934

merged 2 commits into from
Jul 28, 2022

Conversation

ematipico
Copy link
Contributor

Summary

This PR upgrades eleventy package inside our website. The version we had was really old.
I fixed some regressions that popped out.

Test Plan

The deployed website should work

@ematipico ematipico requested a review from a team July 26, 2022 16:32
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 26, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2390975
Status: ✅  Deploy successful!
Preview URL: https://0b55dad4.tools-8rn.pages.dev
Branch Preview URL: https://chore-update-eleventy.tools-8rn.pages.dev

View logs

@github-actions
Copy link

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 45878 45878 0
Passed 44938 44938 0
Failed 940 940 0
Panics 0 0 0
Coverage 97.95% 97.95% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 39 39 0
Passed 36 36 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.31% 92.31% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 5946 5946 0
Passed 395 395 0
Failed 5551 5551 0
Panics 0 0 0
Coverage 6.64% 6.64% 0.00%

ts/babel

Test result main count This PR count Difference
Total 588 588 0
Passed 519 519 0
Failed 69 69 0
Panics 0 0 0
Coverage 88.27% 88.27% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16257 16257 0
Passed 12393 12393 0
Failed 3864 3864 0
Panics 0 0 0
Coverage 76.23% 76.23% 0.00%

Copy link
Contributor

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns related to the upgrade but it seems to me that this PR also contains the recommended rule changes. Can we split the PR?

</h3>
Disallows using an async function as a Promise executor.
</div>
<div class="rule">
<h3 data-toc-exclude id="noCatchAssign">
<a href="/docs/lint/rules/noCatchAssign">noCatchAssign (since v0.7.0)</a>
<a class="header-anchor" href="#noCatchAssign"></a>
<span class="recommended">recommended</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be part of this PR?

@ematipico
Copy link
Contributor Author

ematipico commented Jul 28, 2022

No concerns related to the upgrade but it seems to me that this PR also contains the recommended rule changes. Can we split the PR?

It's a stacked PR, the PR of the recommended rules was merged into this PR. #2937

@ematipico ematipico merged commit ee9da9c into main Jul 28, 2022
@ematipico ematipico deleted the chore/update-eleventy branch July 28, 2022 10:52
IWANABETHATGUY pushed a commit to IWANABETHATGUY/tools that referenced this pull request Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载