This repository was archived by the owner on Aug 31, 2023. It is now read-only.
chore: remove FileId from the codebase
#4134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.
|
a72c8b7 to
6274662
Compare
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
6274662 to
c0f7fc1
Compare
leops
reviewed
Jan 3, 2023
MichaReiser
reviewed
Jan 3, 2023
d02c150 to
7ab04b3
Compare
leops
approved these changes
Jan 4, 2023
| where | ||
| P: Deref, | ||
| { | ||
| if let Resource::File(file) = self { | ||
| Some(file.as_deref()) | ||
| Some(file.deref()) |
There was a problem hiding this comment.
Nit: rather than calling the .deref() method, the idiomatic way of doing this is to use the * operator (eg. &*file)
515e09f to
2f3b5db
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes
FileIdfrom the codebase.FileIdwas needed when we had the old diagnostics. Now that we removed the old diagnostics from the codebase,FileIdcan be removed too.Test Plan
There shouldn't be any change in the current logic, and the testing suite should pass as is.
Documentation