This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): useMediaCaption rule
#4032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
leops
reviewed
Dec 12, 2022
crates/rome_js_analyze/src/analyzers/nursery/use_media_caption.rs
Outdated
Show resolved
Hide resolved
Comment on lines
2
to
3
| <audio {...props} /> | ||
| <video {...props} /> |
There was a problem hiding this comment.
I'm not sure we should match these since props might contains a children property with a track node
There was a problem hiding this comment.
Yeah, I also have mixed feelings about it, but it seems an unlikely scenario.
There was a problem hiding this comment.
Throughout our rules, we decided to not trigger the rules if we have spread props. The main reason is that we don't know the information contained in the object that is being spread.
21ed6ff to
79a9c4b
Compare
ematipico
reviewed
Dec 20, 2022
08a5d6f to
e2a567c
Compare
ematipico
approved these changes
Dec 20, 2022
e2a567c to
2cf1653
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3947.
Test Plan
cargo test -p rome_js_analyze -- use_media_caption