fix: SSL_shutdown on incomplete handshake #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kostas <kostas@dragonflydb.io>
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 77.60% 78.14% +0.54%
==========================================
Files 103 112 +9
Lines 7824 9848 +2024
==========================================
+ Hits 6072 7696 +1624
- Misses 1752 2152 +400 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
romange
reviewed
Jul 12, 2025
util/tls/tls_engine.cc
Outdated
| state_ |= FATAL_ERROR; | ||
| queue_error = ERR_get_error(); | ||
| LOG(WARNING) << "SSL protocol error " << ERROR_DETAILS; | ||
| LOG_EVERY_T(WARNING, 30) << "SSL protocol error " << ERROR_DETAILS; |
There was a problem hiding this comment.
I think LOG_EVERY_T(WARNING, 1) should be good enough.
romange
reviewed
Jul 12, 2025
util/tls/tls_engine.cc
Outdated
| default: | ||
| queue_error = ERR_get_error(); | ||
| state_ |= FATAL_ERROR; | ||
| LOG(WARNING) << "Unexpected SSL error " << ssl_error << " " << ERROR_DETAILS; | ||
| LOG_EVERY_T(WARNING, 30) << "Unexpected SSL error " << ssl_error << " " << ERROR_DETAILS; |
romange
approved these changes
Jul 12, 2025
romange
pushed a commit
that referenced
this pull request
Jul 12, 2025
* fix: SSL_shutdown on incomplete handshake --------- Signed-off-by: kostas <kostas@dragonflydb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not call
SSL_shutdownif the handshake is not complete.Furthermore reduce the
LOG(INFO)because they can flood and steal cpu time.Fixes: #430