Fix rockstor-bootstrap failing due to a timeout on slower hardware #3006
Conversation
As discussed in rockstor#3005, the timeout for the oauth token is too strict on slower hardware. This extends the timeout to 4 seconds read, which is enough for my AMD E-450 system.
|
@hberntsen This is nice thanks. And thanks also for exploring the newer requests timeouts. Our master branch is for stable release maintenance only. Could you please re-present this pull request (close and create a new one), which looks just dandy, but against the testing branch instead. We may end-up cherry picking that commit into master once it's received more field testing; which is the purpose of our testing channel. But ultimately everything in testing ends up in at least the next major stable release anyway - assuming it wasn't reverted. Sorry to have to ask this, however it should be fairly easy as the two branches are almost identical at this point; given we have just embarked on the next testing phase. I'm hoping we can get your fix out in our first testing release of this new phase. |
|
No worries! I've changed the base from master to testing. There is no need to create a new PR for that: press edit in the top right corner in GitHub, now you can edit the title of the PR and just below that change the base. I earlier already rebased against testing but forgot to change this one. |
Fixes #3005, where I described that the timeout for the oauth token is too strict on slower hardware. This extends the timeout to 4 seconds read, which is enough for my AMD E-450 system.