fix: awaited recursive createHandle call #6496 #6563
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d67d2c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@smriti0710 you need to sign-off the commit in order for us to review it/merge it https://github.com/reactioncommerce/reaction/pull/6563/checks?check_run_id=8897369421 |
Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
if the amount was zero then node.amount would return false, hence changed the check to check for undefined. Signed-off-by: Shwetha Shashidhara <shwethaks263@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Test case added while creating the surcharge with amount 0 and undefined Signed-off-by: Shwetha Shashidhara <shwethaks263@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Shwetha Shashidhara <shwethaks263@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Shwetha Shashidhara <shwethaks263@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Shwetha Shashidhara <shwethaks263@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Shwetha Shashidhara <shwethaks263@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Shwetha Shashidhara <shwethaks263@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
e0032c7 to
5bf870b
Compare
|
@delagroove signed off the commit. |
|
@smriti0710 you need to add a changeset to bump the package. A bug fix would be a "patch" level change |
…//github.com/smriti0710/reaction into issue-6496-await-recursive-createHandle-call
…eTagsFromProducts events Signed-off-by: vishalmalu <vishal.malu@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: vishalmalu <vishal.malu@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
if the amount was zero then node.amount would return false, hence changed the check to check for undefined. Signed-off-by: Shwetha Shashidhara <shwethaks263@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Test case added while creating the surcharge with amount 0 and undefined Signed-off-by: Shwetha Shashidhara <shwethaks263@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Shwetha Shashidhara <shwethaks263@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Shwetha Shashidhara <shwethaks263@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Shwetha Shashidhara <shwethaks263@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Shwetha Shashidhara <shwethaks263@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Shwetha Shashidhara <shwethaks263@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Test case added while creating the surcharge with amount 0 and undefined Signed-off-by: Shwetha Shashidhara <shwethaks263@gmail.com>
Signed-off-by: Shwetha Shashidhara <shwethaks263@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Shwetha Shashidhara <shwethaks263@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Shwetha Shashidhara <shwethaks263@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Shwetha Shashidhara <shwethaks263@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Shwetha Shashidhara <shwethaks263@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com>
…//github.com/smriti0710/reaction into issue-6496-await-recursive-createHandle-call
|
Please ignore this PR. Created a new one with the fix : #6565 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6496
Impact: minor
Type: bugfix
Issue
createHandle is a recursive function to determine an available product handle.
It is async due to the database queries which need to be awaited.
The recursive call should be awaited aswell
Solution
Await createHandle.