Move enabling challenge server to settings #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #267 This is a little messy as it needs to handle old environments where we didn't require explicitly setting this. It also has the worst test I've written in a while, but this should bring coverage up a bit.
Codecov Report
@@ Coverage Diff @@
## master #269 +/- ##
==========================================
+ Coverage 96.66% 96.86% +0.19%
==========================================
Files 108 109 +1
Lines 5044 5071 +27
Branches 274 274
==========================================
+ Hits 4876 4912 +36
+ Misses 137 128 -9
Partials 31 31
Continue to review full report at Codecov.
|
|
This appears to be a CodeCov issue. It's flagging the fact that |
jerbob
approved these changes
Apr 3, 2022
0xAda
approved these changes
Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #267
This is a little messy as it needs to handle old environments where we
didn't require explicitly setting this.
It also has the worst test I've written in a while, but this should
bring coverage up a bit.