+
Skip to content

Increase test coverage #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Increase test coverage #247

merged 1 commit into from
Feb 17, 2022

Conversation

0xAda
Copy link
Contributor

@0xAda 0xAda commented Feb 17, 2022

Increases test coverage to from 93.42% to 96.06% locally, I assume codecov will be similar. This also fixes a bug where post_score_explanation wasn't correctly removed from FastChallengeSerializer

@0xAda 0xAda requested review from jchristgit and jerbob February 17, 2022 03:39
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #247 (79c0fa1) into master (0a11954) will increase coverage by 2.05%.
The diff coverage is 99.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
+ Coverage   94.45%   96.51%   +2.05%     
==========================================
  Files         107      108       +1     
  Lines        4800     4966     +166     
  Branches      274      265       -9     
==========================================
+ Hits         4534     4793     +259     
+ Misses        223      140      -83     
+ Partials       43       33      -10     
Impacted Files Coverage Δ
src/admin/tests.py 100.00% <ø> (ø)
src/backend/renderers.py 100.00% <ø> (+50.00%) ⬆️
src/backend/settings/__init__.py 93.84% <ø> (+17.59%) ⬆️
src/challenge/models.py 100.00% <ø> (+14.56%) ⬆️
src/plugins/tests.py 100.00% <ø> (ø)
src/challenge/tests/mixins.py 93.93% <83.33%> (-6.07%) ⬇️
src/backend/tests.py 100.00% <100.00%> (ø)
src/challenge/serializers.py 88.73% <100.00%> (+1.35%) ⬆️
src/challenge/tests/test_models.py 100.00% <100.00%> (ø)
src/challenge/tests/test_utils.py 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a11954...79c0fa1. Read the comment docs.

@thebeanogamer thebeanogamer enabled auto-merge (squash) February 17, 2022 20:21
Copy link
Collaborator

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jchristgit jchristgit force-pushed the increase-test-coverage branch from b28624a to bde3e18 Compare February 17, 2022 21:33
@jchristgit jchristgit disabled auto-merge February 17, 2022 21:33
@jchristgit jchristgit enabled auto-merge February 17, 2022 21:33
@jchristgit jchristgit force-pushed the increase-test-coverage branch from bde3e18 to 79c0fa1 Compare February 17, 2022 21:37
@jchristgit jchristgit merged commit f069a1e into master Feb 17, 2022
@jchristgit jchristgit deleted the increase-test-coverage branch February 17, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载