+
Skip to content

Fix handling of long or duplicate names #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2022
Merged

Fix handling of long or duplicate names #245

merged 2 commits into from
Feb 17, 2022

Conversation

0xAda
Copy link
Contributor

@0xAda 0xAda commented Feb 17, 2022

Cleans up some missed cases from #237

@0xAda 0xAda enabled auto-merge (squash) February 17, 2022 01:04
thebeanogamer
thebeanogamer approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@thebeanogamer thebeanogamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Define a release once merged please.

@codecov
Copy link

codecov bot commented Feb 17, 2022 •
edited
Loading

Codecov Report

Merging #245 (acc1cc7) into master (2d492a6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   94.44%   94.45%   +0.01%     
==========================================
  Files         107      107              
  Lines        4791     4801      +10     
  Branches      273      274       +1     
==========================================
+ Hits         4525     4535      +10     
  Misses        223      223              
  Partials       43       43
Impacted Files Coverage Δ
src/authentication/providers.py 100.00% <ø> (ø)
src/authentication/tests.py 100.00% <100.00%> (ø)
src/team/serializers.py 100.00% <100.00%> (ø)
src/team/tests.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d492a6...acc1cc7. Read the comment docs.

Bentechy66
Bentechy66 approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@Bentechy66 Bentechy66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0xAda 0xAda merged commit e0e216d into master Feb 17, 2022
@0xAda 0xAda deleted the bugfix/invalid-names branch February 17, 2022 20:23
jchristgit added a commit that referenced this pull request Feb 17, 2022
@jchristgit
Rely on database unique constraints
5ed9c55 
PR #245 updated the validators to check for duplicate usernames and
emails by running a query before posting the data. Let's rely on the
database indexes instead, which is more robust. This builds on top of
PR #245's tests to verify the functionality.
@jchristgit jchristgit mentioned this pull request Feb 17, 2022
Merged
0xAda pushed a commit that referenced this pull request Feb 17, 2022
@jchristgit
Rely on database unique constraints (#248)
bd27043 
PR #245 updated the validators to check for duplicate usernames and
emails by running a query before posting the data. Let's rely on the
database indexes instead, which is more robust. This builds on top of
PR #245's tests to verify the functionality.
0xAda added a commit that referenced this pull request Sep 26, 2024
@0xAda
Fix handling of long or duplicate names (#245)
55ff3d2
0xAda pushed a commit that referenced this pull request Sep 26, 2024
@jchristgit @0xAda
Rely on database unique constraints
d4e7057 
PR #245 updated the validators to check for duplicate usernames and
emails by running a query before posting the data. Let's rely on the
database indexes instead, which is more robust. This builds on top of
PR #245's tests to verify the functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebeanogamer thebeanogamer thebeanogamer approved these changes

@Bentechy66 Bentechy66 Bentechy66 approved these changes

@jchristgit jchristgit Awaiting requested review from jchristgit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xAda @thebeanogamer @Bentechy66
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载