Ignore return values of generators #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Definitely the right change. Are you worried about this breaking existing code out there? |
jcheng5
approved these changes
Nov 4, 2024
A bit worried, but I'm more worried about getting the API right for future users, especially if coro usage increases with new Shiny / elmer use cases. |
c4a50e7 to
3d136aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now return
exhausted()instead oflast_value()in generators. Fixes #51.This is different from the JS behaviour where an iterator is allowed to return a value with the exhaustion sentinel, e.g.
{value: "something", done: true}. In contrast we discard the return value entirely. This is consistent with our sentinel model and simpler. I may be missing a use case for returning the value as in JS but I don't think we're missing out much?The generator state machines still keep track of last values because this is used in async functions where we do want to return that value.