qlik-oss · glooms · Jul 17, 2019 · Jul 17, 2019 · Jul 17, 2019 · Jul 17, 2019
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -18,16 +18,22 @@ jobs:
       - run:
           name: Linting
           command: |
+            go fmt ./...
+            git diff --exit-code
             go get -u golang.org/x/lint/golint
             golint -set_exit_status
+            # golint adds stuff to go.mod and go.sum that mess
+            # with git status --porcelain later
+            git checkout go.mod go.sum
       - run:
           name: Test
           command: go test -v -race ./...
       - run:
           name: Check if documentation needs to be updated
           command: |
+            rm docs/*.md
             ./corectl generate-docs
-            git diff --exit-code --name-only docs/*.md
+            if [[ ! -z $(git status --porcelain) ]]; then exit 1; fi
       - run:
           name: Check if changes has been done to the CLI API
           command: |

diff --git a/docs/corectl_bookmark_set.md b/docs/corectl_bookmark_set.md
diff --git a/docs/corectl_config.md b/docs/corectl_config.md
diff --git a/internal/config.go b/internal/config.go
@@ -159,7 +159,6 @@ func ReadCertificates(certificatesPath string) *tls.Config {
 	return tlsConfig
 }
 
-
 // AddValidProp adds the given property to the set of valid properties.
 func AddValidProp(propName string) {
 	validProps[propName] = struct{}{}

diff --git a/internal/config_test.go b/internal/config_test.go
@@ -8,6 +8,7 @@ import (
 	"github.com/stretchr/testify/assert"
 	"gopkg.in/yaml.v2"
 )
+
 var source = []byte(`test: ${_TEST1_}
 nested:
   nest2:

diff --git a/internal/modeldata.go b/internal/modeldata.go
@@ -7,8 +7,8 @@ import (
 	"net/http"
 	neturl "net/url"
 
-	"github.com/qlik-oss/enigma-go"
 	"github.com/qlik-oss/corectl/internal/rest"
+	"github.com/qlik-oss/enigma-go"
 )
 
 // ModelMetadata defines all available metadata around the data model.

diff --git a/internal/rest/app.go b/internal/rest/app.go
@@ -4,9 +4,9 @@ import (
 	"crypto/tls"
 	"encoding/json"
 	"fmt"
-	"os"
-	neturl "net/url"
 	"net/http"
+	neturl "net/url"
+	"os"
 )
 
 // ImportApp imports a local app into the engine using the rest api
@@ -28,9 +28,9 @@ func ImportApp(appPath string, engine *neturl.URL, headers http.Header, certs *t
 	defer file.Close()
 	req := &http.Request{
 		Method: "POST",
-		URL: url,
+		URL:    url,
 		Header: headers,
-		Body: file,
+		Body:   file,
 	}
 	appInfo := &RestNxApp{}
 	statusCodes := &map[int]bool{

diff --git a/internal/rest/caller.go b/internal/rest/caller.go
@@ -56,6 +56,6 @@ func Call(req *http.Request, certs *tls.Config, result interface{}, statusCodes
 // Removes path and query escapes an app id.
 func adaptAppID(appID string) string {
 	split := strings.Split(appID, "/")
-	adaptedID := split[len(split) - 1]
+	adaptedID := split[len(split)-1]
 	return neturl.QueryEscape(adaptedID)
 }
diff --git a/internal/rest/metadata.go b/internal/rest/metadata.go
@@ -14,7 +14,7 @@ func ReadRestMetadata(appID string, engine *neturl.URL, headers http.Header, cer
 	url.Path = fmt.Sprintf("/v1/apps/%s/data/metadata", adaptAppID(appID))
 	req := &http.Request{
 		Method: "GET",
-		URL: url,
+		URL:    url,
 		Header: headers,
 	}
 	result := &RestMetadata{}

diff --git a/internal/urlparser.go b/internal/urlparser.go
@@ -8,7 +8,7 @@ import (
 	"github.com/spf13/viper"
 )
 
-func GetEngineURL() (*url.URL) {
+func GetEngineURL() *url.URL {
 	engine := viper.GetString("engine")
 	if engine == "" {
 		FatalError("engine URL not specified")
@@ -86,7 +86,6 @@ func parseEngineURL(engine string) (*url.URL, error) {
 	return u, nil
 }
 
-
 func buildWebSocketURL(ttl string) string {
 	u := GetEngineURL()
 	// Only modify the URL path if there is no path set
-Original file line number
+Diff line change
@@ Expand Up / @@ -8,6 +8,7 @@ import ( @@
     	"github.com/stretchr/testify/assert"
     	"gopkg.in/yaml.v2"
     )
     var source = []byte(`test: ${_TEST1_}
     nested:
       nest2:
@@ Expand Down @@