This repository was archived by the owner on Sep 28, 2021. It is now read-only.
Isolate tests #131
Merged
Isolate tests #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wennmo
reviewed
Feb 20, 2019
main.go
Outdated
| } | ||
|
|
||
| for _, command := range []*cobra.Command{removeCmd} { | ||
| command.PersistentFlags().Bool("suppress", false, "Suppress confirm") |
There was a problem hiding this comment.
Maybe extend the description a little e.g. Suppress all confirmation dialogues
test/corectl_integration_test.go
Outdated
| teardownTest := setupTest(t, tt) | ||
| defer teardownTest(t, tt) | ||
|
|
||
| // |
There was a problem hiding this comment.
Should there be a comment here? 😉
main.go
Outdated
| confirmed = askForConfirmation(fmt.Sprintf("Do you really want to delete the app: %s?", app)) | ||
| } | ||
|
|
||
| if confirmed || viper.GetString("suppress") == "true" { |
There was a problem hiding this comment.
Maybe its easier if we let askForConfirmation handle the suppress flag? That way we don't need to implement this logic in all methods that would require a confirm dialog later on.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.