reduce bytes length for memory saving, closes #16 #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitabwire
requested changes
Jan 15, 2024
There was a problem hiding this comment.
@sun-jiao thanks for this contribution, could you qualify that the change does not affect the generation of the id.
a binary xid is 12 bytes in length or 20 chars in length if converted to a string.
I guess if you can add just a simple test to always hold this condition as the truth would be great.
pitabwire
approved these changes
May 14, 2024
|
@sun-jiao the change is actually on point, I am adding a test to re confirm this. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests passed. If you have any comments, please feel free to leave them.