+
Skip to content

Enabled HomeController additional methods #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enabled HomeController additional methods #44

wants to merge 2 commits into from

Conversation

mhco
Copy link

@mhco mhco commented May 17, 2018

If the controller for a specified path doesn't exist, then it will search the HomeController.php for the method. If the method exists in HomeController, it fires it; if the method doesn't exist, it shows the error message.

mhco added 2 commits May 17, 2018 15:47
@mhco
Enabled HomeController additional methods
1a89be5 
If the controller for a specified path doesn't exist, then it will search the HomeController.php for the method. If the method exists in HomeController, it fires it; if the method doesn't exist, it shows the error message.
@mhco
Changed $page to $this->url_controller for error pages and home page
d9f6e24 
$this->url_controller was probably kept away from error pages before so that a redirect could happen. With the new $this->url, that is unnecessary, and adds inconsistency the code. This should fix that.
@gokaybiz
Copy link

gokaybiz commented Sep 7, 2018 •
edited
Loading

http://localhost/index/home/index/index
http://localhost/home/index/index/index
No errors, but bad seo 🖌️
Needs a little bit fix for unused parameters i think.

@gokaybiz
Copy link

gokaybiz commented Sep 7, 2018 •
edited
Loading 

        if (func_num_args() > 1)
            return (new \Mini\Controller\ErrorController())->index();
        else {
            if (func_get_args() != null && func_get_args()[0] == "do") {
                //doSomething
                header("Location: ".URL);
            } else
                return (new \Mini\Controller\ErrorController())->index();
        }

http://localhost/index/blabla returns error (404).
http://localhost/index/do redirects to http://localhost/ successfully.
http://localhost/index/xx/xx (more than one parameters) gives error (404)
I developed that but I believe there is a better way from my way. Thanks in advance...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mhco @gokaybiz
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载