+
Skip to content

Clarify PR template #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Clarify PR template #243

merged 2 commits into from
Oct 15, 2021

Conversation

haipinglu
Copy link
Member

Fixes #242.

Description

Clarify reviewer/label selection in the PR template

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

@haipinglu haipinglu requested a review from shuo-zhou October 14, 2021 20:44
@haipinglu haipinglu added the documentation Improvements or additions to documentation label Oct 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021

Codecov Report

Merging #243 (3df2d4a) into main (69a4fa4) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
- Coverage   92.34%   92.32%   -0.03%     
==========================================
  Files          45       45              
  Lines        4587     4574      -13     
==========================================
- Hits         4236     4223      -13     
  Misses        351      351              
Impacted Files Coverage Δ
kale/loaddata/videos.py 86.66% <0.00%> (-0.71%) ⬇️
kale/pipeline/domain_adapter.py 89.23% <0.00%> (-0.07%) ⬇️
kale/embed/video_res3d.py 97.34% <0.00%> (-0.05%) ⬇️
kale/loaddata/multi_domain.py 92.01% <0.00%> (-0.03%) ⬇️
kale/loaddata/image_access.py 96.79% <0.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69a4fa4...3df2d4a. Read the comment docs.

@haipinglu haipinglu merged commit 7450305 into main Oct 15, 2021
@haipinglu haipinglu deleted the clarify-PR-template branch October 15, 2021 07:43
@github-actions github-actions bot mentioned this pull request Apr 12, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载