+
Skip to content

Conversation

devpersi
Copy link
Contributor

@devpersi devpersi commented Aug 4, 2025

What does this PR do?

This PR abstracts several functionalities away from cog.py, renaming it to welcome_and_coc_cog.py, fixes the link in coc message formatting, avoids sending dms by creating a thread named welcome-{username} (deleted when the user reacts to the coc message or leaves the guild).

How to test changes / Special notes to the reviewer

Run the bot, join the server with a user with dms turned off, react to the coc message.

@devpersi devpersi requested a review from a team as a code owner August 4, 2025 05:51
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 30.00000% with 21 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
bot/cog.py 25.00% 19 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ
bot/messages.py 100.00% <100.00%> (ø)
bot/cog.py 84.78% <25.00%> (-15.22%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@devpersi devpersi force-pushed the coc-message-no-dms branch 2 times, most recently from 52de33f to 4825143 Compare August 8, 2025 15:17
@devpersi devpersi force-pushed the coc-message-no-dms branch from b2a9dc2 to d14b9a8 Compare August 9, 2025 10:03
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! Great job! 🎉

Left some very minor comments only.

Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lysnikolaou lysnikolaou merged commit 1ae54c0 into pygreece:main Aug 22, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载