-
Notifications
You must be signed in to change notification settings - Fork 3
Handle member role assignment when the user has dms turned off #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
52de33f
to
4825143
Compare
b2a9dc2
to
d14b9a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall! Great job! 🎉
Left some very minor comments only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does this PR do?
This PR abstracts several functionalities away from cog.py, renaming it to welcome_and_coc_cog.py, fixes the link in coc message formatting, avoids sending dms by creating a thread named welcome-{username} (deleted when the user reacts to the coc message or leaves the guild).
How to test changes / Special notes to the reviewer
Run the bot, join the server with a user with dms turned off, react to the coc message.