Release v1.2.0 #10
Release v1.2.0 #10
Conversation
There was a problem hiding this comment.
Hello @bleykauf . I'm working on some improvements related to deployment topics we discussed in the past. I'm trying to adapt to linien 0.8.0 and I encountered this issue.
| python_requires=">=3.5", | ||
| install_requires=[ | ||
| "myhdl>=0.11", | ||
| "rpyc>=4.0,<5.0", |
There was a problem hiding this comment.
I thought that rpyc >5.0 compatibility was fixed in version 0.3.2 of linien (according to linien's CHANGELOG.md).
There was a problem hiding this comment.
The problem with rpyc>=5.0 was that it was incompatible with the outdated python version of RedPitaya OS 1.0. The fix in that version is that the installed version was explicitly set to <5.0 to avoid conflicts between server and client. RedPitaya OS 2.0 apparently now has a stable release and the next version of Linien will only support OS 2.0.
That means that the requirement will be rpyc>=5.0,<6.0 from then on.
There was a problem hiding this comment.
The problem with rpyc>=5.0 was that it was incompatible with the outdated python version of RedPitaya OS 1.0
Python supports constraining that with the python version, as explained here: https://stackoverflow.com/questions/21082091/install-requires-based-on-python-version
There was a problem hiding this comment.
But we have to make sure that we always use the same version of rpyc for server and client since they are incompatible. Will be upgraded to >=5.0,<6.0 with the next release.
This version is required for linien-common, due to RedPitaya OS Python version limitation. See: linien-org/pyrp3#10 (comment)
No description provided.