Makefile: Use $CPPFLAGS and $LDFLAGS if they are set #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @jmarshall, the Debian packagers agree with this PR. |
The bwa makefile doesn't set these two itself, but the environment or make command line might set any of CC/CPPFLAGS/CFLAGS/LDFLAGS/LIBS. Use $(CPPFLAGS) when compiling and $(LDFLAGS) when linking so they can be used to customise the build. Remove $(DFLAGS) from link commands as these preprocessor options are irrelevant for linking.
|
@lh3 Please also consider applying this PR, which makes it easier for Debian/Bioconda/etc to adjust the build flags. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile convention is to use CC/CPPFLAGS/CFLAGS/LDFLAGS/LIBS variables in the compile and link rules. This adds
$(CPPFLAGS)and$(LDFLAGS)to the appropriate rules, so that these two can also be used to customise the build in the expected conventional way — in addition to the already present$(CC),$(CFLAGS), and$(LIBS).In particular, bioconda and Debian would take advantage of these variables in their packaging scripts. Supersedes and closes #247.