-
-
Notifications
You must be signed in to change notification settings - Fork 154
为Table提供扩展以实现实体类查询api #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from origin
# Conflicts: # buildSrc/src/main/kotlin/ktorm.maven-publish.gradle.kts
# Conflicts: # buildSrc/src/main/kotlin/ktorm.maven-publish.gradle.kts
首先感谢你的 PR,这个功能很有想法,在特定场景下确实能解决一些痛点,但我还是决定不合并,主要是处于以下考量:
|
非常感谢您的答复。其实一开始确实是打算只作为独立工具使用的,但是部分逻辑可能涉及到了一些内部API,似乎无法直接的在第三方情况下应用。如果这样的话不知这类API是否会考虑公开或者提供类似功能的公开方法呢?印象中有比如根据Column获取具体实体类中对应属性值的方法之类的。 |
vincentlauvlwj
added a commit
that referenced
this pull request
Jun 3, 2022
嗯,刚刚开放了几个内部 API 给外部扩展使用,会在 3.5.0 版本发布,你可以看一下 adaf213 |
好的~感谢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
为
Table
提供一个扩展类,并实现通过对应实体类来进行查询的APIEntitySequence.filterBy
和Query.whereBy
,例如: