don't cause stackoverflow in whereWithConditions/whereWithOrConditions #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually we don't need another expression type, simply refactoring the public inline fun Query.whereWithConditions(block: (MutableList<ColumnDeclaring<Boolean>>) -> Unit): Query {
var conditions: List<ColumnDeclaring<Boolean>> = ArrayList<ColumnDeclaring<Boolean>>().apply(block)
if (conditions.isEmpty()) {
return this
} else {
while (conditions.size > 1) {
conditions = conditions.chunked(2) { chunk ->
if (chunk.size == 2) chunk[0] and chunk[1] else chunk[0]
}
}
return this.where { conditions[0] }
}
} |
|
I've updated the PR with your version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
whereWithConditionsandwhereWithOrConditionsso they don't cause stack overflows.This is done by introducing a new expression type:
VarargsExpression.VarargsExpressionwraps a collection ofColumnDeclaring<Boolean>. On output it wraps eachColumnDeclaring<Boolean>in parenthesis and joins them together with the operator. For code like a list of(t.id eq 1) and (t.departmentId eq 100), the resulting SQL looks like:This SQL is different than what was built before. Previously
whereWithConditions/whereWithOrConditionstreatedandandoras purely binary operators, nesting subsequent expressions in increasingly deep parenthesis. SQL allows us to skip the nesting which this takes advantage of.Fixes #327