+
Skip to content

fix table not containing schema in insert method #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

xujif
Copy link
Contributor

@xujif xujif commented Nov 14, 2020

Copy link
Member

@vincentlauvlwj vincentlauvlwj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不好意思,最近有点忙,所以这么晚才回复。首先感谢你的反馈,这确实是一个 bug,当初支持 catalog/schema 的时候忘记修改这个地方,是我的疏忽。

把这一行改成 write(expr.table) 确实能解决这个 bug,但是其实问题不止有这一处。存在同样问题的地方一共有 5 个:

  • SqlFormatter.visitInsert
  • SqlFormatter.visitInsertFromQuery
  • MySqlFormatter.visitInsertOrUpdate
  • MySqlFormatter.visitBulkInsert
  • PostgresSqlFormatter.visitInsertOrUpdate

解决 bug 的话,把相关的地方一起改完,才算是一个完整的 PR 哦。

最后,如果你是第一次提交 PR,请同时修改 build.gradle 文件,把你的 GitHub ID 和邮箱留在开发者信息中(89 行),这样可以让更多人看到你的贡献。

@vincentlauvlwj vincentlauvlwj changed the base branch from master to v3.3.x December 1, 2020 15:52
@vincentlauvlwj vincentlauvlwj merged commit 0722ca0 into kotlin-orm:v3.3.x Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载