fix: reduce memory allocation on Column.label used for accessing in query #564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the simple example as provided in the documentation provided (see https://www.ktorm.org/en/query.html)
this will actually generate a label per row per column in order to access the element in the table via call stack of:
however, this getter initializes a string on every instance, so if you have 1000 rows, this will generate 1000 strings x the number of columns that are all the same for every call.
Alternative approaches
As always, thanks for reading and maintaining the library!