Support SAN for Go 1.15+ #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from Go 1.15+ Certificate without subjectAltName will fail with error: "x509: certificate relies on legacy Common Name field" More info: golang/go#39568 This is only for Domain name and does not support IP Address: https://godoc.org/crypto/x509#Certificate
gabriel
approved these changes
Aug 21, 2020
|
Thanks! |
|
You're welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from Go 1.15+ Certificate without subjectAltName will fail with error: "x509: certificate relies on legacy Common Name field"
More info: golang/go#39568
This is only for Domain names and does not support IPAddresses: https://godoc.org/crypto/x509#Certificate
I did not use scripts/test to test if this will affect other parts of the code.