Refactor createRegisterUrl() and add tests
#80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the createRegisterUrl functionality to use a more concise implementation and adds tests to validate its behavior, closing #79.
- Refactored createRegisterUrl in lib/keycloak.js to use object-spread for setting the register action.
- Added new tests in test/tests/register-url.spec.ts for both registration URL with all options and with default options.
- Updated test executor in test/support/test-executor.ts to expose createRegisterUrl for testing.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/tests/register-url.spec.ts | Added tests that validate the registration URL endpoints and query parameters. |
| test/support/test-executor.ts | Introduced a createRegisterUrl method to bridge test calls with the Keycloak client. |
| lib/keycloak.js | Refactored createRegisterUrl to use a spread operator, simplifying the previous conditional logic. |
923d314 to
a7855a9
Compare
Closes keycloak#79 Signed-off-by: Jon Koops <jonkoops@gmail.com>
a7855a9 to
f272035
Compare
douglaspalmer
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79