Refactor createLogoutUrl() to use standardized URL APIs
#77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#76 Signed-off-by: Jon Koops <jonkoops@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the creation of logout URLs to leverage standardized URL APIs. The changes include new tests for different logout scenarios, an updated TestExecutor method to expose createLogoutUrl, and modifications to the Keycloak library to use URLSearchParams for query parameter construction.
- Added comprehensive tests for logout URL generation.
- Introduced a createLogoutUrl method to the TestExecutor.
- Updated Keycloak’s createLogoutUrl to construct query parameters using URLSearchParams.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/tests/logout-url.spec.ts | Added tests to validate logout URL creation with different options. |
| test/support/test-executor.ts | Introduced createLogoutUrl method leveraging page.evaluate. |
| lib/keycloak.js | Refactored createLogoutUrl to use URLSearchParams for GET requests. |
Comments suppressed due to low confidence (1)
lib/keycloak.js:489
- While the use of URLSearchParams is a good improvement, consider using the URL constructor (e.g. new URL(url)) to build the logout URL and then update its search parameters. This may improve clarity and ensure proper URL encoding.
kc.createLogoutUrl = function(options) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #76