+
Skip to content

Have a single module with synced classes from keycloak/keycloak #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2024
Merged

Have a single module with synced classes from keycloak/keycloak #50

merged 1 commit into from
Sep 12, 2024

Conversation

pskopek
Copy link
Collaborator

@pskopek pskopek commented Sep 12, 2024 •
edited
Loading

Closes #34

@pskopek
Have a single module with synced classes from keycloak/keycloak Clo…
a65dec3 
…ses #keycloak-client-34

Signed-off-by: Peter Skopek <pskopek@redhat.com>
@pskopek pskopek self-assigned this Sep 12, 2024
@pskopek pskopek added this to the 26.0.0 milestone Sep 12, 2024
mposolda
mposolda approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure if the name of the maven module name can be only keycloak-client-common as the fact that sources are synced might be an "implementation detail" from the point of view of the consumer of that maven artifact? But does not matter much to me, so approving.

@pskopek
Copy link
Collaborator Author

pskopek commented Sep 12, 2024

Not 100% sure if the name of the maven module name can be only keycloak-client-common as the fact that sources are synced might be an "implementation detail" from the point of view of the consumer of that maven artifact? But does not matter much to me, so approving.

I just wanted to stress that this module is purely synced and should not be used directly by anybody.

@mposolda
Copy link
Contributor

Not 100% sure if the name of the maven module name can be only keycloak-client-common as the fact that sources are synced might be an "implementation detail" from the point of view of the consumer of that maven artifact? But does not matter much to me, so approving.

I just wanted to stress that this module is purely synced and should not be used directly by anybody.

That works for me. Thanks for the clarification!

@mposolda mposolda merged commit 4c892a2 into keycloak:main Sep 12, 2024
5 checks passed
@pskopek pskopek deleted the keycloak-client-34 branch September 12, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonkoops jonkoops jonkoops approved these changes

@mposolda mposolda mposolda approved these changes

Assignees

@pskopek pskopek

Labels
None yet
Projects
None yet
Milestone
26.0.0
Development

Successfully merging this pull request may close these issues.

Have a single module with synced classes from keycloak/keycloak
3 participants
@pskopek @mposolda @jonkoops
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载