Add UserAttributeToScopeMapper with duplicate-safety #43383
Draft
+190
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on integrating this suggested improvement into upstream, @adhamahmad :-) And additionally, thank you for adding the duplicate check to my original code! Since the code, for the most part, still relies on my original suggestion, please credit me as a Co-author. Thanks! |
8e208f3 to
6bc520d
Compare
Related to keycloak#32157 Co-authored-by: Florian Rademacher <florian.rademacher@codecentric.de> Signed-off-by: Adham Ahmed Hussein Mahrous <adhamahmad541@gmail.com>
6bc520d to
09db870
Compare
|
Thanks @frademacher for your your original implementation! I’ve amended the commit to include you as a co-author. |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #32157
Summary
Implements the
UserAttributeToScopeMapperproposed in issue #32157.This mapper allows mapping a user attribute into the token
scopefield asclaim:value.Details
Includes duplicate handling to prevent multiple identical entries in the scope.
Questions
I'd like feedback on whether this should:
UserAttributeMapper.Related issue: #32157
cc @stianst