+
Skip to content

Run account console resource tests in parallel #43316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2025
Merged

Run account console resource tests in parallel #43316

merged 1 commit into from
Oct 14, 2025
+96 −105

Conversation

jonkoops
Copy link
Contributor

@jonkoops jonkoops commented Oct 9, 2025 •
edited
Loading

Refactors the account console resource tests (resources.spec.ts) to execute in parallel, speeding up test execution. Additionally, two tests with repeated logic have been merged into one. This PR also refactors some other code to make use of explicit resource management to automatically close browsers.

Closes #43315

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Oct 9, 2025
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.oauth.ClientAuthSignedJWTTest#testClientWithGeneratedKeysJKS

Keycloak CI - Base IT (6)

java.lang.AssertionError: 

Expected: (a value greater than <1854703220688L> and a value less than <1854703230688L>)
     but: a value greater than <1854703220688L> <1854703219000L> was less than <1854703220688L>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
...

Report flaky test

@jonkoops jonkoops changed the title Run account console resource tests in parralel Run account console resource tests in parallel Oct 9, 2025
@jonkoops jonkoops force-pushed the isolate-resouces-test branch from 431d2b3 to 0f72aad Compare October 10, 2025 14:56
@jonkoops jonkoops marked this pull request as ready for review October 10, 2025 14:56
@jonkoops jonkoops requested review from a team as code owners October 10, 2025 14:56
@jonkoops
Run account console resource tests in parralel
5f9562e 
Closes keycloak#43315

Signed-off-by: Jon Koops <jonkoops@gmail.com>
@jonkoops jonkoops force-pushed the isolate-resouces-test branch from 0f72aad to 5f9562e Compare October 10, 2025 15:07
@ssilvert ssilvert merged commit 55c53d3 into keycloak:main Oct 14, 2025
78 checks passed
@jonkoops jonkoops deleted the isolate-resouces-test branch October 14, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssilvert ssilvert ssilvert approved these changes

+1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove serial test execution for resources.spec.ts

2 participants

@jonkoops @ssilvert
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载