DOC: Explain Containerfile usage and fix docker build example #41213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#41029 Signed-off-by: Somin Park <ps4708@naver.com>
vmuzikar
reviewed
Jul 17, 2025
| @@ -24,6 +24,8 @@ For the best start up of your {project_name} container, build an image by runnin | |||
| This step will save time in every subsequent start phase of the container image. | |||
|
|
|||
| === Writing your optimized {project_name} Containerfile | |||
| NOTE: A Containerfile is functionally identical to a Dockerfile and uses the same syntax. The term "Containerfile" is used to be more tool-agnostic, especially in non-Docker environments like Podman or Buildah. When using Docker, you have two options: either name your file `Dockerfile` (which Docker expects by default), or keep the name `Containerfile` and specify it explicitly using the `-f` flag: `docker build -f Containerfile -t mykeycloak .` | |||
vmuzikar
reviewed
Jul 17, 2025
Comment on lines
+152
to
+156
| podman build . -t mykeycloak | ||
| # or for Docker (specify the Containerfile explicitly): | ||
| docker build -f Containerfile . -t mykeycloak | ||
| # or rename Containerfile to Dockerfile and use: | ||
| docker build . -t mykeycloak |
There was a problem hiding this comment.
@ahus1 IIRC, we also have a logic somewhere to replace podman|docker with just podman, correct? So this won't work for prod either, AFAICT.
There was a problem hiding this comment.
I'll check once I review that follow-up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41029