+
Skip to content

Generate a UUID to be the JTI instead of reusing the nonce. #40007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

Generate a UUID to be the JTI instead of reusing the nonce. #40007

merged 1 commit into from
Jul 9, 2025

Conversation

MichaelCordingley
Copy link
Contributor

@MichaelCordingley MichaelCordingley commented May 27, 2025 •
edited
Loading

Fixes #40160

@MichaelCordingley MichaelCordingley requested a review from a team as a code owner May 27, 2025 20:32
@MichaelCordingley MichaelCordingley force-pushed the dont-reuse-uuids branch 2 times, most recently from e722e1a to ddef90f Compare May 27, 2025 20:35
@ahus1
Copy link
Contributor

ahus1 commented May 28, 2025

Thank you for this PR. To understand the context of this PR better, please create a GitHub issue first. If you think the current behavior is a bug, then create a bug issue. Then link this PR to the issue as outlined in the CONTRIBUTING.md file.

cc: @rmartinc, @mposolda

@MichaelCordingley
Copy link
Contributor Author

MichaelCordingley commented Jun 2, 2025 •
edited
Loading

Done

@MichaelCordingley MichaelCordingley mentioned this pull request Jun 3, 2025
Closed
2 tasks
@mposolda mposolda self-assigned this Jun 25, 2025
@MichaelCordingley @mposolda
Generate a UUID to be the JTI instead of reusing the nonce.
78ba2c1 
Signed-off-by: michael.cordingley <michael.cordingley@upstart.com>
@mposolda mposolda force-pushed the dont-reuse-uuids branch from ddef90f to 78ba2c1 Compare July 9, 2025 09:16
mposolda
mposolda approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. I think PR is correct behavior as long as tests are OK

@mposolda mposolda added the status/ready Ready to be merged label Jul 9, 2025
@mposolda mposolda merged commit 20a4dc2 into keycloak:main Jul 9, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mposolda mposolda mposolda approved these changes

Assignees

@mposolda mposolda

Labels
status/ready Ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Action Tokens Copy Nonce Into JTI
3 participants
@MichaelCordingley @ahus1 @mposolda
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载