+
Skip to content

Fix typo in consent scope #40787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2025
Merged

Fix typo in consent scope #40787

merged 2 commits into from
Jul 7, 2025

Conversation

SferaDev
Copy link
Contributor

Closes #40786

@SferaDev SferaDev requested review from a team as code owners June 30, 2025 09:37
@SferaDev SferaDev mentioned this pull request Jun 30, 2025
Open
@ahus1 ahus1 added the status/hold PR should not be merged. On hold for later. label Jun 30, 2025
@ahus1
Copy link
Contributor

ahus1 commented Jun 30, 2025

Adding a "hold" label as this would be a breaking change to the current users of the API

@SferaDev SferaDev force-pushed the typo-display-text branch from a363d75 to 2192b72 Compare July 3, 2025 13:30
ahus1
ahus1 requested changes Jul 3, 2025
View reviewed changes
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. See below for one suggested change.

core/src/main/java/org/keycloak/representations/account/ConsentScopeRepresentation.java Outdated
Comment on lines 26 to 30
/**
* @deprecated Use {@link #displayText} instead. This field will be removed in KC 27.0.
*/
@Deprecated
private String displayTest;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove this deprecated field, and only keep the new one? Then the old getter/setter would only point to that new field. IMHO this should be enough to create the right JSON, and parse the JSON correctly, assuming people will send one or the other.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I've double checked and the getter and setter in the representation are enough. Thanks!

image

@ahus1 ahus1 self-assigned this Jul 3, 2025
@SferaDev SferaDev force-pushed the typo-display-text branch from 2192b72 to f230603 Compare July 3, 2025 17:06
@SferaDev SferaDev requested a review from ahus1 July 3, 2025 17:07
@SferaDev @ahus1
Deprecate displayTest
db3eaaa 
Closes keycloak#40786

Signed-off-by: Alexis Rico <sferadev@gmail.com>
@ahus1 ahus1 force-pushed the typo-display-text branch from f230603 to d6443fd Compare July 7, 2025 15:45
@ahus1
Review
d6ae4f8 
Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
@ahus1 ahus1 force-pushed the typo-display-text branch from d6443fd to d6ae4f8 Compare July 7, 2025 15:45
@ahus1 ahus1 enabled auto-merge (squash) July 7, 2025 15:46
@ahus1 ahus1 removed the status/hold PR should not be merged. On hold for later. label Jul 7, 2025
@ahus1 ahus1 merged commit c834e74 into keycloak:main Jul 7, 2025
76 checks passed
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Jul 7, 2025
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.federation.ldap.LDAPReadOnlyTest#testReadOnlyUserGetsPermanentlyLocked

Keycloak CI - Base IT (5)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
...

Report flaky test

@SferaDev SferaDev deleted the typo-display-text branch July 7, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@ahus1 ahus1 ahus1 approved these changes

Assignees

@ahus1 ahus1

Labels
flaky-test team/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in Consent Scope Representation
2 participants
@SferaDev @ahus1
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载