+
Skip to content

make abstract class AbstractUserRoleMappingMapper public #40766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2025
Merged

make abstract class AbstractUserRoleMappingMapper public #40766

merged 1 commit into from
Jun 28, 2025

Conversation

dasniko
Copy link
Contributor

@dasniko dasniko commented Jun 27, 2025

(was package-private)

closes #40765

@dasniko
make abstract class AbstractUserRoleMappingMapper public (was package…
d6bf00a 
…-private)

closes keycloak#40765

Signed-off-by: Niko Köbler <niko@n-k.de>
@dasniko dasniko requested a review from a team as a code owner June 27, 2025 18:01
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Jun 27, 2025
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.cluster.UserFederationInvalidationClusterTest#crudWithFailover

Keycloak CI - Clustering IT

java.lang.RuntimeException: java.lang.IllegalStateException: Keycloak unexpectedly died :(
	at org.keycloak.testsuite.arquillian.containers.KeycloakQuarkusServerDeployableContainer.start(KeycloakQuarkusServerDeployableContainer.java:71)
	at org.jboss.arquillian.container.impl.ContainerImpl.start(ContainerImpl.java:185)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:137)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:133)
...

Report flaky test

@dasniko
Copy link
Contributor Author

dasniko commented Jun 27, 2025

I don't think that this flaky test is related to this PR

@ahus1
Copy link
Contributor

ahus1 commented Jun 28, 2025

I'm ok to change it, but as usual, please note that you use APIs in the service package at your own risk, and they might change in patch or minor releases.

@ahus1 ahus1 merged commit e7e4ce8 into keycloak:main Jun 28, 2025
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@ahus1 ahus1 ahus1 approved these changes

Assignees
No one assigned
Labels
flaky-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make abstract class AbstractUserRoleMappingMapper public
2 participants
@dasniko @ahus1
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载