+
Skip to content

Windows fixes for 26.0 branch (26.0) #40743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2025
Merged

Windows fixes for 26.0 branch (26.0) #40743

merged 2 commits into from
Jun 26, 2025

Conversation

rmartinc
Copy link
Contributor

Closes #40583
Closes #40593

PR: #40588 #40595
Commit: 265ba23 df5a030
PR branch: backport-40593-26.0
Target branch: https://github.com/keycloak/keycloak/tree/release/26.0

ahus1 and others added 2 commits June 26, 2025 16:34
@ahus1 @rmartinc
Removing the Windows optimization as it is currently unstable
265ba23 
Closs keycloak#40583

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
@rmartinc
Copy restored maven repo to home folder in Windows
df5a030 
Closes keycloak#40593

Signed-off-by: rmartinc <rmartinc@redhat.com>
@rmartinc rmartinc requested a review from a team as a code owner June 26, 2025 15:58
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Jun 26, 2025
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcOidcBrokerTest#testPostBrokerLoginFlowWithOTP_bruteForceEnabled

Keycloak CI - Java Distribution IT (windows-latest - temurin - 17)

java.lang.AssertionError: User should be disabled by brute force.
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.broker.AbstractAdvancedBrokerTest.testPostBrokerLoginFlowWithOTP_bruteForceEnabled(AbstractAdvancedBrokerTest.java:580)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...

Report flaky test

@rmartinc
Copy link
Contributor Author

@mposolda @ahus1 Please re-run the operator CI when you can can. PR contains the two missing windows fixes for 26.0 (windows jobs are failing for other backports needed here).

@ahus1 ahus1 enabled auto-merge (rebase) June 26, 2025 17:56
@ahus1 ahus1 merged commit 718505e into keycloak:release/26.0 Jun 26, 2025
75 of 77 checks passed
@rmartinc
Copy link
Contributor Author

Thanks @ahus1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@ahus1 ahus1 ahus1 approved these changes

Assignees
No one assigned
Labels
flaky-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmartinc @ahus1
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载