+
Skip to content

Make rolling-updates-v2 preview feature #40732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2025
Merged

Make rolling-updates-v2 preview feature #40732

merged 2 commits into from
Jun 26, 2025

Conversation

mhajas
Copy link
Contributor

@mhajas mhajas commented Jun 26, 2025

Closes #38883

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Jun 26, 2025
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.federation.ldap.LDAPReadOnlyTest#testReadOnlyUserGetsPermanentlyLocked

Keycloak CI - Base IT (5)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
...

Report flaky test

org.keycloak.testsuite.cluster.RealmInvalidationClusterTest#crudWithFailover

Keycloak CI - Store IT (mysql)

java.lang.RuntimeException: java.lang.IllegalStateException: Keycloak unexpectedly died :(
	at org.keycloak.testsuite.arquillian.containers.KeycloakQuarkusServerDeployableContainer.start(KeycloakQuarkusServerDeployableContainer.java:71)
	at org.jboss.arquillian.container.impl.ContainerImpl.start(ContainerImpl.java:185)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:137)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:133)
...

Report flaky test

@mhajas
Make rolling-updates-v2 preview feature
b7b67c9 
Closes keycloak#38883

Signed-off-by: Michal Hajas <mhajas@redhat.com>
@mhajas mhajas force-pushed the 38883-Upgrade-command-rolling-updates-for-patch-releases-step-2-preview branch from 6abeb00 to b7b67c9 Compare June 26, 2025 13:31
@mhajas mhajas marked this pull request as ready for review June 26, 2025 14:45
@mhajas mhajas requested review from a team as code owners June 26, 2025 14:45
ryanemerson
ryanemerson reviewed Jun 26, 2025
View reviewed changes
docs/guides/server/update-compatibility.adoc Outdated
@@ -147,7 +147,7 @@ The feature `rolling-updates` is disabled.
[[rolling-updates-for-patch-releases]]
== Rolling updates for patch releases

WARNING: This behavior is currently in an experimental mode, and it is not recommended for use in production.
WARNING: This behavior is currently in a preview mode, and it is not recommended for use in production.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"in preview mode"

ryanemerson
ryanemerson reviewed Jun 26, 2025
View reviewed changes
quarkus/tests/integration/src/test/java/org/keycloak/it/cli/dist/FeaturesDistTest.java
@@ -33,7 +33,7 @@ public class FeaturesDistTest {
private static final String PREVIEW_FEATURES_EXPECTED_LOG = "Preview features enabled: " + Arrays.stream(Profile.Feature.values())
.filter(feature -> feature.getType() == Profile.Feature.Type.PREVIEW)
.filter(feature -> {
Set<Profile.Feature> versions = Profile.getFeatureVersions(feature.getKey());
Set<Profile.Feature> versions = Profile.getFeatureVersions(feature.getUnversionedKey());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is a bug. The method is calling getOrderedFeatures which returns map of f.getUnversionedKey() -> to all versions.

Therefore using versioned key here does not make sense and never finds anything. There was no versioned feature in preview mode at the moment so me changing ROLLING_UDPATES_V2 to preview triggered the bug.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining. Please create an issue to track the bug.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is worth the time creating an issue for one line change in tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I should have looked at the code closely, I made wrong assumptions based upon my reading of your explanation. I agree an issue is unnecessary.

@mhajas
Address comments
b9bdd25 
Signed-off-by: Michal Hajas <mhajas@redhat.com>
@ryanemerson ryanemerson self-requested a review June 26, 2025 15:30
@mhajas mhajas enabled auto-merge (squash) June 26, 2025 16:25
ahus1
ahus1 approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on previous reviews.

@mhajas mhajas merged commit d944823 into keycloak:main Jun 26, 2025
80 checks passed
@mhajas mhajas deleted the 38883-Upgrade-command-rolling-updates-for-patch-releases-step-2-preview branch June 26, 2025 17:28
shawkins pushed a commit to shawkins/keycloak that referenced this pull request Jul 1, 2025
@mhajas @shawkins
Make rolling-updates-v2 preview feature (keycloak#40732)
41f05ca 
Closes keycloak#38883
Signed-off-by: Michal Hajas <mhajas@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanemerson ryanemerson ryanemerson approved these changes

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@ahus1 ahus1 ahus1 approved these changes

Assignees
No one assigned
Labels
flaky-test team/cloud-native
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade command rolling updates for patch releases / step 2: preview
3 participants
@mhajas @ryanemerson @ahus1
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载