Verification of external facebook token via "debug token" endpoint #40720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@graziang Did you manage to have successfully working external-to-internal token exchange with Facebook token and with I think that right now, the steps for testing this might be like:
|
Closes keycloak#40163 Signed-off-by: Giuseppe Graziano <g.graziano94@gmail.com>
|
@mposolda Thanks for the review, I messed up the requirements. I've updated the PR and successfully tested everything manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40163
Added a check to ensure that the
client_idmatches theapp_idcontained in the response from the custom Facebook/debug_tokenendpoint. To invoke the debug endpoint, an "app access token" is required, which can either be in the formclient_id|client_secretor obtained via the client credentials grant. However, I noticed that with the default settings, the "app access token" is returned from client credential grant asclient_id|client_secretin plain so I skipped this additional step. Since we don't have automated tests, I also added the option to disable this verification (enabled by default).