fix: refining breaking behavior #40697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes: keycloak#39063 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
|
@ahus1 Sorry, missed you as a reviewer. Let me know if you have any concerns and we can address it as a follow-up. |
This was referenced Jun 27, 2025
shawkins
added a commit
to shawkins/keycloak
that referenced
this pull request
Jul 1, 2025
closes: keycloak#39063 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the simplest change to default to warning only when using the old ambiguous format for buildtime spi options. Without adding more complexity it does mean that users can specify both new and old formats simultaneously and they will both be treated as buildtime - however we'll check for the new format first, so it is dominant. For the purposes of builds mixing the formats will result in additional auto-builds or errors that builds are needed as we'll persist what the user builds with.
closes: #39063