+
Skip to content

Fix and enable account-ui tests #40671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/js-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ jobs:
working-directory: js

- name: Run Playwright tests
run: pnpm --fail-if-no-match --filter ${{ env.WORKSPACE }} test:integration
run: pnpm --fail-if-no-match --filter ${{ env.WORKSPACE }} test
working-directory: js

- name: Upload Playwright report
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ test.describe("Account linking", () => {

// Expect an error shown that the account cannot be unlinked
await expect(page.getByTestId("last-alert")).toContainText(
"You can't remove last federated identity as you don't have a password.",
"You can not remove last federated identity as you do not have a password.",
);
});
});
Expand Down
2 changes: 1 addition & 1 deletion js/apps/account-ui/test/applications.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ test.describe("Applications test", () => {
await page.goto("/");
await expect(page).toHaveURL(getAdminUrl());
await page.waitForURL(getAdminUrl());
await expect(page.getByTestId("realmSelector")).toBeVisible();
await expect(page.getByTestId("options-toggle")).toBeVisible();

await page.goto(getRootPath());
await page.waitForURL(getAccountUrl());
Expand Down
8 changes: 4 additions & 4 deletions js/apps/account-ui/test/personal-info/personal-info.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
await login(page, user, "jdoe", realm);

await page.locator("#alternatelang").click();
await page.waitForSelector("text=Italiano");

Check warning on line 70 in js/apps/account-ui/test/personal-info/personal-info.spec.ts

View workflow job for this annotation

GitHub Actions / Account UI

Unexpected use of page.waitForSelector()

await page.locator("#alternatelang").click();
await page.locator("*:focus").press("Control+A");
Expand All @@ -80,10 +80,10 @@
test("render long list of locales as typeahead", async ({ page }) => {
await login(page, user, "jdoe", realm);

await page.locator("#locale").click();
await page.locator("#attributes\\.locale").click();
await page.waitForSelector("text=Italiano");

Check warning on line 84 in js/apps/account-ui/test/personal-info/personal-info.spec.ts

View workflow job for this annotation

GitHub Actions / Account UI

Unexpected use of page.waitForSelector()

await page.locator("#locale").click();
await page.locator("#attributes\\.locale").click();
await page.locator("*:focus").press("Control+A");
await page.locator("*:focus").pressSequentially("S");
await expect(page.getByText("Italiano")).toHaveCount(0);
Expand Down Expand Up @@ -126,14 +126,14 @@
);

await login(page, user, "pwd", realm);
await page.locator("#locale").click();
await page.locator("#attributes\\.locale").click();
page.getByRole("option").filter({ hasText: "Deutsch" });
await page.getByRole("option", { name: "English" }).click();
await page.getByTestId("save").click();
await page.reload();

expect(
page.locator("#locale").filter({ hasText: /^English$/ }),
page.locator("#attributes\\.locale").filter({ hasText: /^English$/ }),
).toBeDefined();
});
});
2 changes: 1 addition & 1 deletion js/apps/account-ui/test/referrer.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ test.describe("Signing in with referrer link", () => {
}) => {
const referrer = "security-admin-console";
const referrerUrl = getAdminUrl();
const referrerName = "security admin console";
const referrerName = "Security Admin Console";

const queryParams = {
referrer,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ missingIdentityProviderMessage=Identity provider not specified.
invalidFederatedIdentityActionMessage=Invalid or missing action.
identityProviderNotFoundMessage=Specified identity provider not found.
federatedIdentityLinkNotActiveMessage=This identity is not active anymore.
federatedIdentityRemovingLastProviderMessage=You can''t remove last federated identity as you don''t have a password.
federatedIdentityRemovingLastProviderMessage=You can not remove last federated identity as you do not have a password.
federatedIdentityBoundOrganization=You cannot remove the link to an identity provider associated with an organization.
identityProviderRedirectErrorMessage=Failed to redirect to identity provider.
identityProviderRemovedMessage=Identity provider removed successfully.
Expand Down
Loading
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载