+
Skip to content

[26.2.x] Missing Quarkus flag for Syslog counting framing #40669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mabartos
Copy link
Contributor

  • Closes Missing Quarkus flag for syslog logging #39893
  • Changed the default value for log-syslog-counting-framing to false, instead of protocol-dependent used for main
  • It means there will be no breaking changes as we only expose the knob for the counting framing

@mabartos mabartos changed the title Missing Quarkus flag for Syslog counting framing [26.2.x] Missing Quarkus flag for Syslog counting framing Jun 23, 2025
Closes keycloak#39893

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@mabartos mabartos linked an issue Jun 24, 2025 that may be closed by this pull request
2 tasks
@mabartos mabartos marked this pull request as ready for review June 24, 2025 10:44
@mabartos mabartos requested review from a team as code owners June 24, 2025 10:44
@mabartos
Copy link
Contributor Author

@shawkins Could you please also check this backport? Please look at the description. Thanks!

@mabartos mabartos requested a review from shawkins June 24, 2025 11:06
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just wondering if we need an upgrade note in the pr.

@mabartos mabartos self-assigned this Jun 24, 2025
@vmuzikar
Copy link
Contributor

This is basically a new feature. I do not think we should be adding that to 26.2. I understand it solves an issue for a particular syslog receiver, still I wouldn't consider it a bug that justifies backporting.

@mabartos
Copy link
Contributor Author

I do not think we should be adding that to 26.2. I understand it solves an issue for a particular syslog receiver, still I wouldn't consider it a bug that justifies backporting.

@vmuzikar I'm on top of the fence - considering 26.2 will live for some time, inability to use majority of syslog receivers might be an issue and providing quarkus.properties to change only this simple property seems to me like overkill - mainly for containers and operator. That's why I thought it might be good to provide the option itself as well and change the default value to false to not introduce any breaking change.

On the other hand, I understand your point, and both options work for me, even with the fact some users/customers might face difficulties to configure Keycloak with Syslog - so I'm more inclined to include it.

Please, let me know what you think about this consideration. Thanks!

@vmuzikar
Copy link
Contributor

@mabartos Thank you for elaborating.

Let me loop in also @ahus1 as he's more involved in the Observability area.

I appreciate it might be a blocker for some users. Though it's not a regression, or even a bug per se. Keycloak 26.2 will soon reach EOL in the community, and AFAIK we haven't heard any RFE from the product side for this. Hence -1 from my side for backporting this.

@vmuzikar vmuzikar requested a review from ahus1 June 26, 2025 09:44
@mabartos
Copy link
Contributor Author

I appreciate it might be a blocker for some users. Though it's not a regression, or even a bug per se. Keycloak 26.2 will soon reach EOL in the community, and AFAIK we haven't heard any RFE from the product side for this. Hence -1 from my side for backporting this.

Ok, works for me not to backport it and close this as 26.3 is behind a door for community. We have a workaround described in the issue, so we can potentially react ad-hoc :) I think it's not necessary to involve more people as we have a conclusion.

@mabartos mabartos closed this Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Quarkus flag for syslog logging
3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载