-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[26.2.x] Missing Quarkus flag for Syslog counting framing #40669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
quarkus/config-api/src/main/java/org/keycloak/config/LoggingOptions.java
Show resolved
Hide resolved
Closes keycloak#39893 Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@shawkins Could you please also check this backport? Please look at the description. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just wondering if we need an upgrade note in the pr.
This is basically a new feature. I do not think we should be adding that to 26.2. I understand it solves an issue for a particular syslog receiver, still I wouldn't consider it a bug that justifies backporting. |
@vmuzikar I'm on top of the fence - considering 26.2 will live for some time, inability to use majority of syslog receivers might be an issue and providing quarkus.properties to change only this simple property seems to me like overkill - mainly for containers and operator. That's why I thought it might be good to provide the option itself as well and change the default value to On the other hand, I understand your point, and both options work for me, even with the fact some users/customers might face difficulties to configure Keycloak with Syslog - so I'm more inclined to include it. Please, let me know what you think about this consideration. Thanks! |
@mabartos Thank you for elaborating. Let me loop in also @ahus1 as he's more involved in the Observability area. I appreciate it might be a blocker for some users. Though it's not a regression, or even a bug per se. Keycloak 26.2 will soon reach EOL in the community, and AFAIK we haven't heard any RFE from the product side for this. Hence -1 from my side for backporting this. |
Ok, works for me not to backport it and close this as 26.3 is behind a door for community. We have a workaround described in the issue, so we can potentially react ad-hoc :) I think it's not necessary to involve more people as we have a conclusion. |
log-syslog-counting-framing
tofalse
, instead ofprotocol-dependent
used for main