-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Fixed the IDs comparison logic #40667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Closes keycloak#40666 Signed-off-by: Anchels <mishtitov@gmail.com>
...jpa/src/main/java/org/keycloak/connections/jpa/updater/liquibase/lock/CustomLockService.java
Outdated
Show resolved
Hide resolved
@Anchels thank you for the PR, are you able to add a test for this case as well? |
Co-authored-by: Steven Hawkins <shawkins@redhat.com> Signed-off-by: Anchels <42744001+Anchels@users.noreply.github.com>
@shawkins sorry, I don't have experience with writing tests |
Not sure if this fix is enough - see https://github.com/keycloak/keycloak/blob/main/model/jpa/src/main/java/org/keycloak/connections/jpa/updater/liquibase/lock/CustomLockService.java#L130-L139 The |
…IDs from enum Signed-off-by: Anchels <mishtitov@gmail.com>
@sguilhen, could you please see if the latest changes will help fix the problem? Or should we combine |
To be on the safe side I would combine them. |
Closes keycloak#40666 Signed-off-by: Anchels <mishtitov@gmail.com>
Closes #40666