-
Notifications
You must be signed in to change notification settings - Fork 7.4k
fix(i18n): add missing comma before 'a' in Polish password reset message #40471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Corrected punctuation in the UI string to follow proper Polish grammar rules. Signed-off-by: kwiateusz <kwiateusz@users.noreply.github.com>
@kwiateusz - thank you for this PR. Can you please ask a second Polish native speaker to review this PR as outlined in the translation.md file? |
This is a comma, separating main clause of a sentence from subordinate clause of the sentence. This is correct. Source: https://pl.wikipedia.org/wiki/Zdanie_podrzędnie_złożone |
The Polish translation fix looks correct |
Thank you for the reviews. When there we find 2-3 volunteers who want to regularly review Polish translations, we can set up Weblate for that. Please drop a note with your Weblate username in this discussion thread: #9270 (comment) Thread more about the process in the |
I've already signed up to maintain Polish lang. Thanks for approve and sorry for not creating issue, I didn't think that for such a small change I also had to create one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.cluster.GroupInvalidationClusterTest#crudWithFailover
|
Closes #40485
Corrected punctuation in the UI string to follow proper Polish grammar rules.