+
Skip to content

fix(i18n): add missing comma before 'a' in Polish password reset message #40471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

kwiateusz
Copy link
Contributor

@kwiateusz kwiateusz commented Jun 13, 2025

Closes #40485

Corrected punctuation in the UI string to follow proper Polish grammar rules.

Corrected punctuation in the UI string to follow proper Polish grammar rules.

Signed-off-by: kwiateusz <kwiateusz@users.noreply.github.com>
@kwiateusz kwiateusz requested review from a team as code owners June 13, 2025 10:01
@ahus1 ahus1 self-assigned this Jun 13, 2025
@ahus1
Copy link
Contributor

ahus1 commented Jun 13, 2025

@kwiateusz - thank you for this PR. Can you please ask a second Polish native speaker to review this PR as outlined in the translation.md file?

@d-gran
Copy link

d-gran commented Jun 13, 2025

@kwiateusz - thank you for this PR. Can you please ask a second Polish native speaker to review this PR as outlined in the translation.md file?

This is a comma, separating main clause of a sentence from subordinate clause of the sentence. This is correct.

Source: https://pl.wikipedia.org/wiki/Zdanie_podrzędnie_złożone
This is similar to: https://stlcc.edu/student-support/academic-success-and-tutoring/writing-center/writing-resources/subordination-complex-sentences.aspx

@augustyniakamil
Copy link

The Polish translation fix looks correct

@ahus1
Copy link
Contributor

ahus1 commented Jun 13, 2025

Thank you for the reviews. When there we find 2-3 volunteers who want to regularly review Polish translations, we can set up Weblate for that. Please drop a note with your Weblate username in this discussion thread: #9270 (comment)

Thread more about the process in the translation.md file in this repository.

@ahus1 ahus1 enabled auto-merge (squash) June 13, 2025 19:51
@kwiateusz
Copy link
Contributor Author

I've already signed up to maintain Polish lang. Thanks for approve and sorry for not creating issue, I didn't think that for such a small change I also had to create one.

@ahus1 ahus1 merged commit 00099b1 into keycloak:main Jun 13, 2025
75 checks passed
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.cluster.GroupInvalidationClusterTest#crudWithFailover

Keycloak CI - Clustering IT

java.lang.RuntimeException: java.lang.IllegalStateException: Keycloak unexpectedly died :(
	at org.keycloak.testsuite.arquillian.containers.KeycloakQuarkusServerDeployableContainer.start(KeycloakQuarkusServerDeployableContainer.java:71)
	at org.jboss.arquillian.container.impl.ContainerImpl.start(ContainerImpl.java:185)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:137)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:133)
...

Report flaky test

@kwiateusz kwiateusz deleted the patch-2 branch June 13, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Polish translation is missing a comma
4 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载