+
Skip to content

fix: removing lifecylce in initContainers #40455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

Conversation

shawkins
Copy link
Contributor

closes: #40360

@shawkins shawkins requested review from a team as code owners June 12, 2025 14:14
@shawkins shawkins requested a review from pruivo June 12, 2025 14:14
ahus1
ahus1 previously approved these changes Jun 12, 2025
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as of previous review. Thank you for this fix!

@ahus1 ahus1 self-assigned this Jun 12, 2025
@ahus1
Copy link
Contributor

ahus1 commented Jun 12, 2025

restarting the failed job hoping that it will succeed.

@shawkins
Copy link
Contributor Author

restarting the failed job hoping that it will succeed.

That was my mistake, which should now be corrected.

closes: keycloak#40360

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.federation.ldap.LDAPReadOnlyTest#testReadOnlyUserGetsPermanentlyLocked

Keycloak CI - Base IT (5)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
...

Report flaky test

Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@shawkins shawkins requested a review from ahus1 June 13, 2025 14:25
@ahus1 ahus1 requested a review from pruivo June 13, 2025 18:11
@ahus1
Copy link
Contributor

ahus1 commented Jun 13, 2025

@pruivo - can you please re-review?

@ahus1 ahus1 modified the milestone: 26.3.0 Jun 16, 2025
@ahus1 ahus1 merged commit bd14961 into keycloak:main Jun 16, 2025
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Keycloak-Operator]: Rolling Updates -- Strategy=Auto, operator error keycloak-update-job is invalid -- Strategy=Explicit, operator always replaces
3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载