fix: WebAuthNPasswordless authenticator is incorrectly sorted after all other authenticators in alternative flows #39081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ed0637 to
c5dd5e9
Compare
121a67d to
b2ddf4f
Compare
469dfda to
a7364a2
Compare
|
@mposolda - maybe the core-clients team can have a look at this PR. |
…rted after all other authenticators in alternative flows Signed-off-by: LAPTOP-42\Roman.Benedikt <roman.benedikt@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21140
The AuthenticationSelectionResolver currently sorts the WebAuthNPasswordless authenticator after all other alternative executions. As a result, it cannot be the first login option if, for example, a "UsernamePasswordForm" is also present in the flow.
To fix this behavior, I ensure that the WebAuthNPasswordless authenticator is added to the typeAuthExecMap if a user context is available, or to nonCredentialExecutions if not.
This means that: