Ignore protoLock checks when building Keycloak with JDK #39961
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#39861 Signed-off-by: Michal Hajas <mhajas@redhat.com>
ryanemerson
approved these changes
May 26, 2025
abstractj
approved these changes
May 26, 2025
robson90
pushed a commit
to robson90/keycloak
that referenced
this pull request
Jul 9, 2025
Closes keycloak#39861 Signed-off-by: Michal Hajas <mhajas@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39861
This was failing in recent GHA test runs and we don't need to check this here since it was already checked by the global build.
There may be other occurrences of 429 mentioned in #39861 but it seems it is pretty much stable in recent runs, therefore I think removing this is enough for now and we can reopen later if it happens again.
Let me know what you think.