fix: ensuring exit codes are handled consistently #38661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2347344 to
2b85351
Compare
closes: keycloak#38161 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
|
We were making the test launch mode pull double duty. It was both causing an early exit, and preventing System.exit calls. Rather than removing the launch mode from the raw dist, I'm using it only for the early exit. Now we attempt to detect what type of launch were using by the classloader and adjust our exit handling accordingly. @pedroigor does this work for you / embedded usage? |
vmuzikar
approved these changes
Apr 11, 2025
Comment on lines
-171
to
+187
| int exitCode = ApplicationLifecycleManager.getExitCode(); | ||
|
|
||
| if (isTestLaunchMode() || isNonServerMode()) { | ||
| // in test mode we exit immediately | ||
| // we should be managing this behavior more dynamically depending on the tests requirements (short/long lived) | ||
| Quarkus.asyncExit(exitCode); | ||
| Quarkus.asyncExit(ApplicationLifecycleManager.getExitCode()); | ||
| } else { | ||
| Quarkus.waitForExit(); | ||
| } | ||
|
|
||
| return exitCode; | ||
| return ApplicationLifecycleManager.getExitCode(); |
There was a problem hiding this comment.
Jus out of curiosity, why is this change needed? Why can't we store the exit code in a var?
There was a problem hiding this comment.
That's a potential bug, we don't want to store it because it could change while the waiting for exit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #38161