-
Notifications
You must be signed in to change notification settings - Fork 7.7k
[Test framework MVP] ImpersonationDisabledTest #35057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
stianst
merged 2 commits into
keycloak:main
from
lhanusov:34494/impersonation-disabled-test
Nov 19, 2024
Merged
[Test framework MVP] ImpersonationDisabledTest #35057
stianst
merged 2 commits into
keycloak:main
from
lhanusov:34494/impersonation-disabled-test
Nov 19, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
stianst
reviewed
Nov 19, 2024
tests/base/src/test/java/org/keycloak/test/admin/ImpersonationDisabledTest.java
Outdated
Show resolved
Hide resolved
stianst
reviewed
Nov 19, 2024
tests/base/src/test/java/org/keycloak/test/admin/ImpersonationDisabledTest.java
Outdated
Show resolved
Hide resolved
stianst
reviewed
Nov 19, 2024
tests/base/src/test/java/org/keycloak/test/admin/ImpersonationDisabledTest.java
Outdated
Show resolved
Hide resolved
stianst
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the completely useless system.out.println.
Would also rework it a little bit at the same time, as the assert.fail should just be immediately after the statement that should fail as that makes it more readable.
Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>
d1af772
to
50e2161
Compare
stianst
reviewed
Nov 19, 2024
tests/base/src/test/java/org/keycloak/test/admin/ImpersonationDisabledTest.java
Outdated
Show resolved
Hide resolved
stianst
reviewed
Nov 19, 2024
tests/base/src/test/java/org/keycloak/test/admin/ImpersonationDisabledTest.java
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Lukas Hanusovsky <61745358+lhanusov@users.noreply.github.com>
50e2161
to
9cbbb12
Compare
stianst
approved these changes
Nov 19, 2024
agagancarczyk
pushed a commit
to agagancarczyk/keycloak
that referenced
this pull request
Nov 28, 2024
* [Test framework MVP] ImpersonationDisabledTest Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com> * Apply suggestions from code review Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Lukas Hanusovsky <61745358+lhanusov@users.noreply.github.com> --------- Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com> Signed-off-by: Lukas Hanusovsky <61745358+lhanusov@users.noreply.github.com> Co-authored-by: Stian Thorgersen <stian@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #34494
Adding new server functionality: featuresDisabled()