+
Skip to content

Conversation

lhanusov
Copy link
Contributor

Part of #34494

Adding new server functionality: featuresDisabled()

keycloak-github-bot[bot]

This comment was marked as resolved.

@keycloak-github-bot

This comment was marked as resolved.

Copy link
Contributor

@stianst stianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the completely useless system.out.println.

Would also rework it a little bit at the same time, as the assert.fail should just be immediately after the statement that should fail as that makes it more readable.

Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>
@lhanusov lhanusov force-pushed the 34494/impersonation-disabled-test branch from d1af772 to 50e2161 Compare November 19, 2024 08:21
keycloak-github-bot[bot]

This comment was marked as resolved.

@keycloak-github-bot

This comment was marked as resolved.

Co-authored-by: Stian Thorgersen <stian@redhat.com>
Signed-off-by: Lukas Hanusovsky <61745358+lhanusov@users.noreply.github.com>
@lhanusov lhanusov force-pushed the 34494/impersonation-disabled-test branch from 50e2161 to 9cbbb12 Compare November 19, 2024 09:04
@stianst stianst merged commit 7502b9c into keycloak:main Nov 19, 2024
73 checks passed
agagancarczyk pushed a commit to agagancarczyk/keycloak that referenced this pull request Nov 28, 2024
* [Test framework MVP] ImpersonationDisabledTest

Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>

* Apply suggestions from code review

Co-authored-by: Stian Thorgersen <stian@redhat.com>
Signed-off-by: Lukas Hanusovsky <61745358+lhanusov@users.noreply.github.com>

---------

Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>
Signed-off-by: Lukas Hanusovsky <61745358+lhanusov@users.noreply.github.com>
Co-authored-by: Stian Thorgersen <stian@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载